-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(preset): Aws lambda edge #1075
Conversation
β Live Preview ready!
|
Codecov Report
@@ Coverage Diff @@
## main #1075 +/- ##
==========================================
+ Coverage 76.64% 76.66% +0.01%
==========================================
Files 71 72 +1
Lines 7241 7247 +6
Branches 723 723
==========================================
+ Hits 5550 5556 +6
Misses 1690 1690
Partials 1 1
|
@pi0 can we get this PR merged soon ? |
@pi0 @danielroe can we get a review and merge of this pr soon ? |
Hey @pi0 do we have plans to get this merged for the next release? Our team is looking forward to use it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
], | ||
}; | ||
const res: CloudFrontResultResponse = await handler(event); | ||
// responsed CloudFrontHeaders are special, so modify them for testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo
86b7d1c
to
edca69a
Compare
This is looking very good, and it also would be a compatible with SST as demonstrated here https://github.com/jdevdevdev/nuxt-sst/blob/lambda-edge/nuxt-app/server/nitro/preset/entry.ts @pi0 Some presets such as vercel and netlify have multiple presets, while some like cloudflare and azure don't, so I'm not sure what to do here. |
Trying stuff pnpm build conflicts with monorepo pnpm build when installing the package from github Remove prepack and commit dist Improve aws edge code Accept only 1 header with same name for incoming headers Forgot to build Debugging outgoing headers Improving the income headers Removing dist
π Linked issue
β Type of change
π Description
Add AWS Lambda@Edge to the preset.
The current aws-lambda preset is not compatible with the Lambda@Edge
This option is one of the most cost-effective on cloud technologies, it is much faster and more effective than "API Gateway".
I take WinterYukky job as a base, focusing more on ".output/server/index.mjs" and removing the zero config functionalities as there are several CloudFormation templates to deploy, leaving a simpler option to implement inside your CI/CD.
Resolves #79
π Checklist